Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Move the opening logic to the range fields #16175

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[pickers] Move the opening logic to the range fields #16175

wants to merge 8 commits into from
+851 −921

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 14, 2025 •
edited
Loading

In this PR

  • Move the opening logic of the range pickers to be inside the field components
  • Change the opening logic of the single input fields to use an end adornment
  • Change the role and lifecycle of the popper to act like a dialog on desktop range pickers with single input fields (but keep the tooltip behavior for desktop range pickers with multi input fields)

Follow up

  • Make the single input fields the default field for the range pickers
  • Rename the single input fields from SingleInputXXXField to XXXField to show they are the recommended approach? (and keep SingleInputXXXField components until v9 but deprecated)
  • Improve the keyboard navigation on the Date Range Calendar to have a preview when like on hover

Extracted PRs

@flaviendelangle flaviendelangle self-assigned this Jan 14, 2025
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Jan 14, 2025
@mui-bot
Copy link

mui-bot commented Jan 14, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16175--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7dfb813

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 15, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 15, 2025
@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from 3dd4793 to e2c9609 Compare January 15, 2025 13:39
This was referenced Jan 21, 2025
Merged
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 27, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 28, 2025
@flaviendelangle flaviendelangle mentioned this pull request Jan 28, 2025
Merged
2 tasks
@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from a011bf2 to 9939064 Compare January 30, 2025 09:28
@flaviendelangle flaviendelangle mentioned this pull request Jan 30, 2025
Merged
@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from b62852d to 2663c38 Compare January 31, 2025 07:57
@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from 9f1c1eb to b60c0f8 Compare February 4, 2025 07:03
@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from 43b6a3a to f7749c9 Compare February 5, 2025 12:41
@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from f7749c9 to 69b8a5f Compare February 5, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaviendelangle @mui-bot